This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Bring back SpanExporter::ExportForTesting.#137
Merged
g-easy merged 2 commits intocensus-instrumentation:masterfrom Apr 4, 2018
Merged
Bring back SpanExporter::ExportForTesting.#137g-easy merged 2 commits intocensus-instrumentation:masterfrom
g-easy merged 2 commits intocensus-instrumentation:masterfrom
Conversation
- Make StdoutExporter take an ostream. - Make stdout_exporter_test faster (no sleep) and check that the added annotation appears in the output.
isturdy
approved these changes
Mar 29, 2018
Contributor
isturdy
left a comment
isturdy
left a comment
There was a problem hiding this comment.
Should this be StreamExporter now?
Vizerai
approved these changes
Apr 1, 2018
Contributor
Author
|
I'm not sure it's worth renaming, but I thought about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make StdoutExporter take an ostream.
Make stdout_exporter_test faster (no sleep) and check that
the added annotation appears in the output.