This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Update the gRPC stats based on the new spec.#138
Merged
isturdy merged 1 commit intocensus-instrumentation:masterfrom Apr 4, 2018
Merged
Update the gRPC stats based on the new spec.#138isturdy merged 1 commit intocensus-instrumentation:masterfrom
isturdy merged 1 commit intocensus-instrumentation:masterfrom
Conversation
g-easy
approved these changes
Apr 4, 2018
| static const auto measure = stats::MeasureDouble::Register( | ||
| kRpcClientRoundtripLatencyMeasureName, | ||
| "Time between first byte of request sent to last byte of response " | ||
| "received, or terminal error.", |
Contributor
There was a problem hiding this comment.
This is the only description ending in a full stop. Suggest remove it for consistency.
| {RpcServerResponseCount(), recv_message_count_}}, | ||
| {{MethodTagKey(), qualified_method_}, | ||
| {StatusTagKey(), StatusCodeToString(final_info->final_status)}}); | ||
| {{RpcServerSentBytesPerRpc(), static_cast<double>(request_size)}, |
Contributor
There was a problem hiding this comment.
From the server's point of view, isn't request size = recvd bytes?
Contributor
Author
There was a problem hiding this comment.
Good point--switched the variable names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/census-instrumentation/opencensus-specs/blob/master/stats/gRPC.md.