This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Check that WithContext is constructed and destructed on the same thread.#206
Merged
g-easy merged 1 commit intocensus-instrumentation:masterfrom Sep 27, 2018
Merged
Check that WithContext is constructed and destructed on the same thread.#206g-easy merged 1 commit intocensus-instrumentation:masterfrom
g-easy merged 1 commit intocensus-instrumentation:masterfrom
Conversation
This only happens in debug mode (!NDEBUG). Add a death test for it. Fixes census-instrumentation#203.
bogdandrutu
approved these changes
Sep 27, 2018
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
Please don't mark the issue as fixed because we need the same logic in with_span and with_tag_map
Contributor
Author
|
Removed "fixes" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only happens in debug mode (!NDEBUG).
Add a death test for it.