Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Stackdriver stats exporter: make opencensus_task optional.#364

Merged
g-easy merged 6 commits intocensus-instrumentation:masterfrom
g-easy:hostname
Jul 25, 2019
Merged

Stackdriver stats exporter: make opencensus_task optional.#364
g-easy merged 6 commits intocensus-instrumentation:masterfrom
g-easy:hostname

Conversation

@g-easy
Copy link
Copy Markdown
Contributor

@g-easy g-easy commented Jul 24, 2019

Have the exporter fill it in by default, and move the code out of
examples/ and into opencensus/common/internal/.

Have the exporter fill it in by default, and move the code out of
examples/ and into opencensus/common/internal/.
@g-easy
Copy link
Copy Markdown
Contributor Author

g-easy commented Jul 24, 2019

cc @panzhongxian

@g-easy
Copy link
Copy Markdown
Contributor Author

g-easy commented Jul 24, 2019

Oops, need to add the Win32 version.

@bogdandrutu
Copy link
Copy Markdown

What is the background of this change?

@g-easy
Copy link
Copy Markdown
Contributor Author

g-easy commented Jul 24, 2019

You wanted to make opencensus_task optional / filled in automatically, and the OcAgent exporter is going to need Hostname() so I thought to factor them out like this.

@g-easy g-easy merged commit 73969b7 into census-instrumentation:master Jul 25, 2019
@g-easy g-easy deleted the hostname branch July 25, 2019 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants