This repository was archived by the owner on Jul 31, 2023. It is now read-only.
SpanImpl::name() has to grab a lock and copy the name.#369
Merged
g-easy merged 2 commits intocensus-instrumentation:masterfrom Aug 7, 2019
Merged
SpanImpl::name() has to grab a lock and copy the name.#369g-easy merged 2 commits intocensus-instrumentation:masterfrom
g-easy merged 2 commits intocensus-instrumentation:masterfrom
Conversation
Because SetName could change the name at any time. This isn't a bug yet because only running_span_store calls into name(), in a code path we're not using yet. This error can be caught by -Wthread-safety-reference with clang-8 and later.
bogdandrutu
approved these changes
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because SetName could change the name at any time.
This isn't a bug yet because only running_span_store calls into name(),
in a code path we're not using yet.
This error can be caught by -Wthread-safety-reference with clang-8 and
later.