Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Make B3 parser more readable.#376

Merged
g-easy merged 4 commits intocensus-instrumentation:masterfrom
g-easy:b3
Aug 13, 2019
Merged

Make B3 parser more readable.#376
g-easy merged 4 commits intocensus-instrumentation:masterfrom
g-easy:b3

Conversation

@g-easy
Copy link
Copy Markdown
Contributor

@g-easy g-easy commented Aug 13, 2019

No functional change.

No functional change.
Comment thread opencensus/trace/internal/b3.cc Outdated
@g-easy
Copy link
Copy Markdown
Contributor Author

g-easy commented Aug 13, 2019

Benchmark before:

Benchmark                                Time             CPU   Iterations
--------------------------------------------------------------------------
BM_FromB3Headers_128bitTraceId        76.7 ns         76.7 ns      6863265
BM_FromB3Headers_64bitTraceId         45.2 ns         45.2 ns     15227647
BM_FromB3Headers_InvalidTraceId       25.1 ns         25.1 ns     30997309

After:

Benchmark                                Time             CPU   Iterations
--------------------------------------------------------------------------
BM_FromB3Headers_128bitTraceId        74.4 ns         74.4 ns      8511255
BM_FromB3Headers_64bitTraceId         43.1 ns         43.1 ns     16243200
BM_FromB3Headers_InvalidTraceId       29.0 ns         29.0 ns     23450057

@g-easy g-easy merged commit 0aa6ddd into census-instrumentation:master Aug 13, 2019
@g-easy g-easy deleted the b3 branch August 13, 2019 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants