This repository was archived by the owner on Dec 18, 2023. It is now read-only.
Merged
Conversation
lmolkova
suggested changes
Aug 28, 2018
|
|
||
| 1. Create [Application Insights][ai-get-started] resource. | ||
| 1. Set instrumentation key via configuration or global settings | ||
| (`TelemetryConfiguration.Active`). |
There was a problem hiding this comment.
Please don't recommend using TelemetryConfiguration.Active. OC apps are likely .net core apps with dependency injection and using Active causes so much pain
| var exporter = new ApplicationInsightsExporter( | ||
| Tracing.ExportComponent, | ||
| Stats.ViewManager, | ||
| TelemetryConfiguration.Active); // either global or local config can be used |
| [ai-get-started]: https://docs.microsoft.com/azure/application-insights | ||
| [semver]: http://semver.org/ | ||
| [ai-sample]: https://github.com/census-instrumentation/opencensus-csharp/blob/sergkanz/samples/src/Samples/TestApplicationInsights.cs | ||
| [zipkin-sample]: https://github.com/census-instrumentation/opencensus-csharp/blob/sergkanz/samples/src/Samples/TestZipkin.cs No newline at end of file |
There was a problem hiding this comment.
link to the branch: 'sergkanz/samples/src/Samples/TestZipkin.cs'
| this.exportComponent = exportComponent; | ||
| this.viewManager = viewManager; | ||
| this.telemetryConfiguration = telemetryConfiguration; | ||
| this.telemetryConfiguration = telemetryConfiguration ?? TelemetryConfiguration.Active; |
added 2 commits
August 29, 2018 10:59
lmolkova
approved these changes
Aug 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and more warnings fix... still ongoing