This repository was archived by the owner on Dec 18, 2023. It is now read-only.
Merged
Conversation
simonz130
pushed a commit
to simonz130/opencensus-csharp
that referenced
this pull request
Jan 3, 2019
* snupkg, update the linux image and remove travis * removed publish command. It's unnecessary * remove duplicated commands * added comment * use buildProperties instead of arguments * removed comment and updated to ANY 2.2 * latest 2.2
SergeyKanzhelev
pushed a commit
that referenced
this pull request
Jan 4, 2019
* Adding Resource API - v0 - Added IResource definition based on https://github.com/census-instrumentation/opencensus-proto/blob/master/src/opencensus/proto/resource/v1/resource.proto - Added abstract class that implements IResource. Currently it's a scheleton for adding custom resources. This is needed so that the library can identify the resource for which telemetry is collected. * Addressing comments - mainly avoiding exceptions * Updates to the build process (#76) * snupkg, update the linux image and remove travis * removed publish command. It's unnecessary * remove duplicated commands * added comment * use buildProperties instead of arguments * removed comment and updated to ANY 2.2 * latest 2.2 * Adding Resource API - v0 - Added IResource definition based on https://github.com/census-instrumentation/opencensus-proto/blob/master/src/opencensus/proto/resource/v1/resource.proto - Added abstract class that implements IResource. Currently it's a scheleton for adding custom resources. This is needed so that the library can identify the resource for which telemetry is collected. * Addressing comments - mainly avoiding exceptions * Catch up docs updates after release (#79) * readme and changelog updates * fix issues * fix the license warnings (#83) * fix the license and apply NuGet/Announcements#32 * missed a few files * Make span.Name settable, update it with the route info for ASP.NET Core (#80) * better name * make it work * revert wrong addition * addressed code review * fix build failure and added comment for the sampler * added changelog entry * added route into the attributs as well * IList -> IEnumerable (few of them) (#84) * few IList replaced with IEnumerable * parent links from IList to IEnumerable * a few more of IList -> IEnumerable * one more * stats event with IEnumerable now * smal utils method should not use IList * another utility method * allow net45 compilation for abstractions so some common SDKs may take a dependency on it (#86) * Event logging - docs and a single event example. (#85) * documents * first warning was implemented * first version of docs complete * 1) Removed argument.check method and replaced with direct argument checking 2) Added a few events logging 3) Added tests for Resource parsing (labels and resource type) * Fixing build break * Addressed comments: - Changed IList to IEnumerable - Refined error messages to more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnetversion 2.2 to enable snupkg