This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Prefer library version for gRPC instead of shaded.#1825
Merged
songy23 merged 1 commit intocensus-instrumentation:masterfrom Apr 10, 2019
Merged
Prefer library version for gRPC instead of shaded.#1825songy23 merged 1 commit intocensus-instrumentation:masterfrom
songy23 merged 1 commit intocensus-instrumentation:masterfrom
Conversation
bogdandrutu
approved these changes
Apr 10, 2019
dinooliva
approved these changes
Apr 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if the cloud client libraries use a different version of gRPC than opencensus-api, users may need to manually resolve the version conflicts. For example,
If users have both opencensus-stackdriver-exporter and opencensus-api in the same pom.xml file, Maven will complain about version conflicts, or build may succeed but users will get errors at runtime like https://github.com/census-instrumentation/opencensus-java/tree/master/exporters/stats/stackdriver#why-did-i-get-an-error-javalangnosuchmethoderror-comgooglecommon-like-javalangnosuchmethoderrorcomgooglecommonbasethrowablesthrowifinstanceof.
This PR may be able to help with this kind of issue.