This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Stats Benchmarks#1834
Merged
dinooliva merged 1 commit intocensus-instrumentation:masterfrom Apr 9, 2019
dinooliva:stats-benchmarks
Merged
Stats Benchmarks#1834dinooliva merged 1 commit intocensus-instrumentation:masterfrom dinooliva:stats-benchmarks
dinooliva merged 1 commit intocensus-instrumentation:masterfrom
dinooliva:stats-benchmarks
Conversation
rghetia
reviewed
Apr 5, 2019
Contributor
rghetia
left a comment
rghetia
left a comment
There was a problem hiding this comment.
Overall LGTM. Couple of nits.
| private static AttributeValue[] createAttributeValues(int size) { | ||
| AttributeValue[] attributeValues = new AttributeValue[size]; | ||
| for (int i = 0; i < size; i++) { | ||
| attributeValues[i] = AttributeValue.stringAttributeValue(ATTRIBUTE_VALUE + "-i"); |
Contributor
There was a problem hiding this comment.
same as before. should it be ATTRIBUTE_VALUE + "-" + i ?
Contributor
Author
There was a problem hiding this comment.
Good catch - that's actually in the trace benchmarks, which seem to have appeared here with the rebase merge commit issue. I'll put together a new pr to fix the issue.
| switch (attributeType) { | ||
| case "string": | ||
| for (int i = 0; i < size; i++) { | ||
| attributeValues[i] = AttributeValue.stringAttributeValue(ATTRIBUTE_VALUE_STRING + "-i"); |
Contributor
There was a problem hiding this comment.
should this be ATTRIBUTE_VALUE_STRING + "-" + i ?
Contributor
Author
There was a problem hiding this comment.
Similarly, this is part of the trace benchmarks, I'll put together a new pr to fix the issue.
Contributor
|
Looks like rebase created a merge commit. |
rghetia
approved these changes
Apr 9, 2019
Contributor
Author
|
Ta - thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds microbenchmarks for OpenCensus Stats.