This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Exporter/Stats/Stackdriver: Provide Deadline option and don't do retry by default.#1883
Merged
songy23 merged 4 commits intocensus-instrumentation:masterfrom May 7, 2019
Merged
Conversation
dinooliva
reviewed
May 7, 2019
| createMetricDescriptorSettings.setSimpleTimeoutNoRetries(stackdriverDuration); | ||
| createTimeSeriesSettings.setSimpleTimeoutNoRetries(stackdriverDuration); | ||
| } else { | ||
| /* |
Contributor
There was a problem hiding this comment.
Similarly with tracing - iiuc, the only way to get the default retry settings is to explicitly set the deadline - will that negatively impact any customers, i.e. are there customers that have been relying on retries?
Contributor
Author
There was a problem hiding this comment.
Similar comment to #1881 (comment). I'll add a commit to allow users to use a custom MetricClient so that they can use custom settings.
dinooliva
approved these changes
May 7, 2019
dinooliva
approved these changes
May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stackdriver Monitoring part of #1880.