Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Exporter/Stackdriver: Expose unregister API.#1918

Merged
songy23 merged 2 commits intocensus-instrumentation:masterfrom
songy23:unregister-stats-exporter
May 22, 2019
Merged

Exporter/Stackdriver: Expose unregister API.#1918
songy23 merged 2 commits intocensus-instrumentation:masterfrom
songy23:unregister-stats-exporter

Conversation

@songy23
Copy link
Copy Markdown
Contributor

@songy23 songy23 commented May 22, 2019

Fixes #1917.

Copy link
Copy Markdown
Contributor

@dinooliva dinooliva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this API?

@songy23
Copy link
Copy Markdown
Contributor Author

songy23 commented May 22, 2019

Why do you need this API?

See #1917 for background:

I'd like to be able to gracefully shutdown the application, but the lack of StackdriverStatsExporter#unregister prevents this. It's also not possible to use in a container environment as this would fail on repeat deploy.

@songy23 songy23 force-pushed the unregister-stats-exporter branch from 442153d to e0b747d Compare May 22, 2019 22:32
@dinooliva
Copy link
Copy Markdown
Contributor

Ahh - apologies, missed that, thanks!

@songy23 songy23 merged commit 72d915c into census-instrumentation:master May 22, 2019
@songy23 songy23 deleted the unregister-stats-exporter branch May 22, 2019 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StackdriverStatsExporter#unregister

3 participants