This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Provide an api to configure propagation for spring servlet and client#1924
Merged
rghetia merged 4 commits intocensus-instrumentation:masterfrom Jun 10, 2019
Merged
Conversation
songy23
reviewed
Jun 6, 2019
| this.trace = trace; | ||
| } | ||
|
|
||
| /** Trace properties. */ |
| /** Trace properties. */ | ||
| public static class Trace { | ||
|
|
||
| public static final String TRACE_PROPAGATION_TRACE_CONTEXT = "tracecontext"; |
Contributor
There was a problem hiding this comment.
Nit: consider using Enum? Also public fields/methods need to have Javadoc.
dinooliva
reviewed
Jun 6, 2019
| } | ||
|
|
||
| /** Trace properties. */ | ||
| public static class Trace { |
Contributor
There was a problem hiding this comment.
Does this class need to be mutable or would an appropriate constructor/builder be sufficient?
Contributor
Author
There was a problem hiding this comment.
it doesn't need to be mutable. I have made it final. Typically it would used by spring framework. Application code would not use it directly.
Contributor
Author
|
@songy23 , @dinooliva PTAL. |
songy23
approved these changes
Jun 10, 2019
dinooliva
approved these changes
Jun 10, 2019
songy23
approved these changes
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1923