Recording http metrics at host level#1926
Recording http metrics at host level#1926songy23 merged 4 commits intocensus-instrumentation:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Can you please sign the CLA? |
| package io.opencensus.contrib.http.util; | ||
|
|
||
| /** Enum class that determines the granularity at which opencensus http metrics are emitted. */ | ||
| public enum HttpClientMetricGranularity { |
There was a problem hiding this comment.
Not sure why do you need this? What you can do is to always add the HOST tag, but don't change the default views. So you can define your own custom views that include the host :)
There was a problem hiding this comment.
what if some applications have a high cardinality hostname space, for example web crawlers? Metric backends may run into cardinality issues in that case. What do you think?
There was a problem hiding this comment.
If the defined views do not include the HOST we just ignore the tag so no cardinality issue.
There was a problem hiding this comment.
I don't quite get your comment on custom views.
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This reverts commit c02d008.
|
@bogdandrutu - You are right. There is no need to change default views. I could define my own view with the exposed measure. Now, I am just tagging host name and not changing any default views. |
|
@songy23 - I would love to get this change with a release. Could you please help me with that? |
|
I have two PRs pending. I will post them today. we can release later today or tomorrow. |
Host name level opencensus metrics are insanely useful while troubleshooting production issues and we would like to give it back to the community.
HttpClientMetricGranularityto define, at what level, one would like to collect metrics.