This repository was archived by the owner on Dec 23, 2023. It is now read-only.
add spring starter package for opencensus spring integration.#1934
Merged
rghetia merged 3 commits intocensus-instrumentation:masterfrom Jun 12, 2019
Merged
add spring starter package for opencensus spring integration.#1934rghetia merged 3 commits intocensus-instrumentation:masterfrom
rghetia merged 3 commits intocensus-instrumentation:masterfrom
Conversation
songy23
approved these changes
Jun 11, 2019
Contributor
songy23
left a comment
songy23
left a comment
There was a problem hiding this comment.
LGTM, assuming there will be other PRs adding the actual implementation.
| opencensus.spring.trace.propagation = TRACE_PROPAGATION_B3 | ||
| ``` | ||
|
|
||
| [travis-image]: https://travis-ci.org/census-instrumentation/opencensus-java.svg?branch=master |
Contributor
There was a problem hiding this comment.
These links seem to be duplicated with the ones at the bottom.
songy23
approved these changes
Jun 11, 2019
Contributor
songy23
left a comment
songy23
left a comment
There was a problem hiding this comment.
Consider adding package-info.java or an empty class, otherwise build will fail.
Contributor
Author
|
@songy23 you can release it now. |
Contributor
|
Got it, let's do it tomorrow morning :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.