Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Conversation

@sebright2
Copy link
Contributor

The new name is more consistent with TagContextSerializationException.

The new name is more consistent with TagContextSerializationException.
@sebright2 sebright2 force-pushed the deserialization-exception branch from 02068ae to 28f8581 Compare November 1, 2017 02:16
@sebright2 sebright2 added this to the Initial stats API release milestone Nov 1, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.208% when pulling 38c7a2d on sebright:deserialization-exception into d1e5e9f on census-instrumentation:master.

@codecov-io
Copy link

codecov-io commented Nov 1, 2017

Codecov Report

Merging #759 into master will increase coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #759      +/-   ##
============================================
+ Coverage     76.32%   76.35%   +0.02%     
  Complexity      787      787              
============================================
  Files           145      145              
  Lines          3616     3616              
  Branches        343      343              
============================================
+ Hits           2760     2761       +1     
  Misses          788      788              
+ Partials         68       67       -1
Impacted Files Coverage Δ Complexity Δ
...s/tags/propagation/TagContextBinarySerializer.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...ropagation/TagContextDeserializationException.java 100% <ø> (ø) 2 <0> (?)
...gs/propagation/TagContextBinarySerializerImpl.java 100% <ø> (ø) 6 <0> (ø) ⬇️
.../implcore/tags/propagation/SerializationUtils.java 94.11% <80%> (ø) 15 <0> (ø) ⬇️
...census/implcore/trace/export/SpanExporterImpl.java 91.66% <0%> (+1.66%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e5e9f...38c7a2d. Read the comment docs.

@sebright2
Copy link
Contributor Author

@bogdandrutu also agreed with the renaming, so I'll merge this.

@sebright2 sebright2 merged commit ef48449 into census-instrumentation:master Nov 1, 2017
@sebright2 sebright2 deleted the deserialization-exception branch November 1, 2017 02:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants