Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Plug-in gauges into the Metric-Registry and register Metric-Registry with Me…#223

Merged
mayurkale22 merged 1 commit intocensus-instrumentation:masterfrom
mayurkale22:plug-in-gauges
Dec 8, 2018
Merged

Plug-in gauges into the Metric-Registry and register Metric-Registry with Me…#223
mayurkale22 merged 1 commit intocensus-instrumentation:masterfrom
mayurkale22:plug-in-gauges

Conversation

@mayurkale22
Copy link
Copy Markdown
Member

…tricProducer.

The Gauges API work is split into multiple PRs.
Completed:

Current:

  • Plug-in gauges into the registry and register Metric-Registry with MetricProducer.

Next:

  • Plug-in derivedgauges into the registry (dependency with Add derived gauge API #220)
  • Add MetricProducerManager to keep track of all MetricProducers i.e. MetricProducerForRegistry and MetricProducerForStats

Copy link
Copy Markdown
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayurkale22
Copy link
Copy Markdown
Member Author

Thanks @justindsmith @OsvaldoRosado @songy23 for reviews.

@mayurkale22 mayurkale22 merged commit 645e620 into census-instrumentation:master Dec 8, 2018
@mayurkale22 mayurkale22 deleted the plug-in-gauges branch December 8, 2018 05:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants