Add Example applications and documentation#74
Conversation
chingor13
changed the title
tmatsuo
left a comment
tmatsuo
left a comment
There was a problem hiding this comment.
I'm cool to include the skeleton code, but I'm also wondering if there's a clean way of generating the skeleton code from the source somehow.
| "symfony/swiftmailer-bundle": "^2.3.10", | ||
| "symfony/symfony": "3.3.*", | ||
| "twig/twig": "^1.0||^2.0", | ||
| "opencensus/opencensus": "dev-example-apps", |
| "fideloper/proxy": "~3.3", | ||
| "laravel/framework": "5.5.*", | ||
| "laravel/tinker": "~1.0", | ||
| "opencensus/opencensus": "dev-example-apps", |
There was a problem hiding this comment.
It might be tricky, but I think we eventually want to change it from "dev-example-apps"
There was a problem hiding this comment.
Yeah, I needed to set it to something. I'll switch them to dev-master for now.
| "type": "project", | ||
| "require": { | ||
| "silex/silex": "^2.2", | ||
| "opencensus/opencensus": "dev-example-apps", |
| @@ -0,0 +1,19 @@ | |||
| <?php | |||
|
|
|||
| require_once __DIR__ . '/../vendor/autoload.php'; | |||
There was a problem hiding this comment.
What does this app trace?
How about to add an example for tracing the web handlers?
There was a problem hiding this comment.
A root span is created for the main web request which is named after the requested path.
I'll add another inline example within one for the request handlers.
|
|
||
| namespace AppBundle; | ||
|
|
||
| use OpenCensus\Trace\Exporter\StackdriverExporter; |
There was a problem hiding this comment.
Do you need these imports?
There was a problem hiding this comment.
Nope, I'll remove. These were remnants from when I had the integrations directly in AppBundle instead of the OpenCensusBundle
2 participants
Fixes #61