This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Update proto and gen-go package names.#83
Merged
songy23 merged 2 commits intocensus-instrumentation:masterfrom Aug 28, 2018
Merged
Update proto and gen-go package names.#83songy23 merged 2 commits intocensus-instrumentation:masterfrom
songy23 merged 2 commits intocensus-instrumentation:masterfrom
Conversation
odeke-em
approved these changes
Aug 28, 2018
bogdandrutu
reviewed
Aug 28, 2018
| proto_library( | ||
| name = "metrics_proto", | ||
| srcs = ["metrics.proto"], | ||
| srcs = ["v1/metrics.proto"], |
Contributor
There was a problem hiding this comment.
Better to move the BUILD.bazel in the v1 directory otherwise we should encode the version in the bazel library name.
bogdandrutu
approved these changes
Aug 28, 2018
rakyll
approved these changes
Aug 28, 2018
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82.