This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Support AAD authentication #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
requested review from
a team,
aabmass,
hectorhdzg and
songy23
as code owners
hectorhdzg
reviewed
Apr 7, 2021
kryalama
reviewed
Apr 7, 2021
contrib/opencensus-ext-azure/opencensus/ext/azure/common/transport.py
Outdated
Show resolved
Hide resolved
ramthi
suggested changes
Apr 13, 2021
contrib/opencensus-ext-azure/opencensus/ext/azure/common/transport.py
Outdated
Show resolved
Hide resolved
contrib/opencensus-ext-azure/opencensus/ext/azure/common/transport.py
Outdated
Show resolved
Hide resolved
lzchen
force-pushed
the
az
branch
2 times, most recently
from
2e6568d to
238c977
Compare
kryalama
approved these changes
Jun 1, 2021
hectorhdzg
reviewed
Jun 1, 2021
| # server side error (retryable) | ||
| return self.options.minimum_retry_interval | ||
| # Authentication error | ||
| if response.status_code == 401: |
There was a problem hiding this comment.
Can you double check if 403 is possible as well?, I know QuickPulse return it in certain cases would be good to confirm with Breeze
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for AAD auth depends on
azure-coreandazure-identityonly for the exception handling.Refer to this doc for when each exception is thrown. One is a retry case, another is a (possible) drop case.
Users must pass in a TokenCredential to exporter constructors to utilize this feature. Refer to this for a list of valid credential classes.
datadog tests were also causing build errors. Commenting them out for now.