This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Fix zipkin_exporter to export span names and tags correctly#110
Merged
liyanhui1228 merged 2 commits intocensus-instrumentation:masterfrom Jan 31, 2018
Merged
Fix zipkin_exporter to export span names and tags correctly#110liyanhui1228 merged 2 commits intocensus-instrumentation:masterfrom
liyanhui1228 merged 2 commits intocensus-instrumentation:masterfrom
Conversation
wkiser
force-pushed
the
zipkin_exporter
branch
from
7b6a838 to
3ec964f
Compare
liyanhui1228
approved these changes
Jan 31, 2018
Contributor
liyanhui1228
left a comment
liyanhui1228
left a comment
There was a problem hiding this comment.
Thanks for this PR! LGTM, please fix the test coverage and then I'll merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with zipkin jar running locally.