Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Clean up execution context in httplib unit tests#118

Merged
liyanhui1228 merged 1 commit intocensus-instrumentation:masterfrom
liyanhui1228:clean_up
Feb 13, 2018
Merged

Clean up execution context in httplib unit tests#118
liyanhui1228 merged 1 commit intocensus-instrumentation:masterfrom
liyanhui1228:clean_up

Conversation

@liyanhui1228
Copy link
Copy Markdown
Contributor

For #117.

@liyanhui1228 liyanhui1228 requested a review from duggelz February 13, 2018 18:53
@liyanhui1228 liyanhui1228 merged commit 62b4635 into census-instrumentation:master Feb 13, 2018
@liyanhui1228 liyanhui1228 deleted the clean_up branch February 13, 2018 19:15
@bplotnick
Copy link
Copy Markdown
Contributor

Thanks! This fixes the test pollution I reported in #117

Since we might hit this again, Maybe we should have either a TestCase baseclass that does this or a pytest autouse fixture that does this. There's some tradeoffs to each, but I think some mechanism would be useful.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants