This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Add error data to span when an exception is raised in a span context#122
Merged
liyanhui1228 merged 5 commits intocensus-instrumentation:masterfrom Feb 20, 2018
Merged
Conversation
liyanhui1228
suggested changes
Feb 20, 2018
Contributor
liyanhui1228
left a comment
liyanhui1228
left a comment
There was a problem hiding this comment.
LGTM with one comment. Thanks for adding support for StackTrace!
| original_func_name=fn_name, | ||
| file_name=filename, | ||
| line_num=line_num, | ||
| col_num=0, # I don't think this is available in python |
Contributor
There was a problem hiding this comment.
Yeah this is more meaningful for JavaScript.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import os |
Contributor
There was a problem hiding this comment.
Please sort the imports alphabetically.
liyanhui1228
approved these changes
Feb 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.