Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Allow user defined file mode for FileExporter#128

Merged
liyanhui1228 merged 2 commits intocensus-instrumentation:masterfrom
wkiser:file_mode
Mar 6, 2018
Merged

Allow user defined file mode for FileExporter#128
liyanhui1228 merged 2 commits intocensus-instrumentation:masterfrom
wkiser:file_mode

Conversation

@wkiser
Copy link
Copy Markdown
Contributor

@wkiser wkiser commented Mar 6, 2018

fixes #113

:class:`.SyncTransport`. The other option is
:class:`.BackgroundThreadTransport`.

:type file_name: str
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be file_mode.

:class:`.BackgroundThreadTransport`.

:type file_name: str
:param file_name: The file mode to open the output file with.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@liyanhui1228 liyanhui1228 merged commit 44259f5 into census-instrumentation:master Mar 6, 2018
@wkiser wkiser deleted the file_mode branch March 30, 2018 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

file_exporter can't append

2 participants