This repository was archived by the owner on Sep 17, 2025. It is now read-only.
refactor - move header name to propagator (part 1)#216
Merged
liyanhui1228 merged 7 commits intocensus-instrumentation:masterfrom Jul 2, 2018
reyang:bugfix142
Merged
refactor - move header name to propagator (part 1)#216liyanhui1228 merged 7 commits intocensus-instrumentation:masterfrom reyang:bugfix142
liyanhui1228 merged 7 commits intocensus-instrumentation:masterfrom
reyang:bugfix142
Conversation
SergeyKanzhelev
suggested changes
Jun 29, 2018
| from opencensus.trace.span_context import SpanContext | ||
| from opencensus.trace.trace_options import TraceOptions | ||
|
|
||
| _TRACE_PARENT_HEADER_NAME = 'Trace-Parent' |
Member
There was a problem hiding this comment.
W3C name for it is traceparent
Contributor
Author
There was a problem hiding this comment.
updated to traceparent
SergeyKanzhelev
approved these changes
Jun 29, 2018
liyanhui1228
approved these changes
Jul 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #167 and #215, this is part 1. I'll breakdown the fix into several small pull requests.