Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Update README about building from source.#245

Merged
songy23 merged 5 commits intocensus-instrumentation:masterfrom
songy23:readme
Jul 30, 2018
Merged

Update README about building from source.#245
songy23 merged 5 commits intocensus-instrumentation:masterfrom
songy23:readme

Conversation

@songy23
Copy link
Copy Markdown
Contributor

@songy23 songy23 commented Jul 30, 2018

Comment thread README.rst Outdated
pip install opencensus
pipenv install opencensus

1-1. If you want to use the unreleased packages (like stats and tags),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put a todo or a comment that starting with version X these packages will be released.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, done.

Copy link
Copy Markdown
Contributor

@liyanhui1228 liyanhui1228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks not right if click on the pre-view?

@songy23
Copy link
Copy Markdown
Contributor Author

songy23 commented Jul 30, 2018

Indentation looks not right if click on the pre-view?

Done.

@songy23 songy23 merged commit 2f50120 into census-instrumentation:master Jul 30, 2018
@songy23 songy23 deleted the readme branch July 30, 2018 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants