This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Fix bugs in stats library#246
Merged
liyanhui1228 merged 5 commits intocensus-instrumentation:masterfrom Aug 4, 2018
Merged
Conversation
songy23
reviewed
Aug 2, 2018
| self._max = max_ | ||
| self._sum_of_sqd_deviations = sum_of_sqd_deviations | ||
| if bounds is None: | ||
| bounds = [0] |
Contributor
There was a problem hiding this comment.
You can leave bounds and counts_per_bucket as None since they are optional.
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I see, you can leave the bounds as an empty list then.
songy23
reviewed
Aug 2, 2018
| @@ -61,6 +61,9 @@ def main(): | |||
| # Get aggregated stats and print it to console. | |||
| view_data = view_manager.get_view(VIDEO_SIZE_VIEW_NAME) | |||
| pprint(vars(view_data)) # TODO: print more meaningful info for view_data | |||
Contributor
There was a problem hiding this comment.
This TODO can be removed now.
This was referenced Aug 4, 2018
MarceloAquino7
pushed a commit
to CESARBR/opencensus-python
that referenced
this pull request
Aug 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226 #227