This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Fix bug in updating aggregation map.#253
Merged
songy23 merged 4 commits intocensus-instrumentation:masterfrom Aug 23, 2018
Merged
Fix bug in updating aggregation map.#253songy23 merged 4 commits intocensus-instrumentation:masterfrom
songy23 merged 4 commits intocensus-instrumentation:masterfrom
Conversation
liyanhui1228
approved these changes
Aug 23, 2018
Contributor
Author
|
Thanks! |
eduardoemery
pushed a commit
to CESARBR/opencensus-python
that referenced
this pull request
Aug 30, 2018
* Fix bug in updating aggregation map. * Update unit tests. * Use tag_value_aggregation_data_map instead of tag_value_aggregation_map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #231.
_tag_mapandget_tag_mapfromview_data.view_data.record()should always use the given context.ViewData.tag_value_aggregation_mapshould be tuples ofTagValues, rather than individualTagValue.ViewData.tag_value_aggregation_map, usecopy.deepcopy()to create a blankAggregationData.