Document 'google-cloud-trace' and BackgroundThreadTransport#262
Document 'google-cloud-trace' and BackgroundThreadTransport#262liyanhui1228 merged 3 commits intocensus-instrumentation:masterfrom stewartreichling:patch-1
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
| pip install google-cloud-trace | ||
| pipenv install google-cloud-trace | ||
|
|
||
| .. _pip: https://pip.pypa.io |
There was a problem hiding this comment.
This pip and pipenv target are defined at the beginning, please fix this in order to make the CI green.
nox > python setup.py check --restructuredtext --strict
running check
warning: check: Duplicate explicit target name: "pip".
warning: check: Duplicate explicit target name: "pipenv".
error: Please correct your package.
|
Thank you @stewblr for the fix and @liyanhui1228 for the review and merge! @stewblr in the future, in your commit message, please add the phrase README: update Stackdriver*Exporter pip instal and need for BackgroundThreadTransport
Fixes #260and that would have auto-closed this issue after the PR had been merged :) |
|
Will do, thanks for the tip! |
No description provided.