Allow user to instrument a library without enabling tracing (using the NoopTracer)#285
Conversation
…ng the NoopTracer)
…-python into noop-tracer-enhancement-issues-277
| from opencensus.trace.tracers import base | ||
|
|
||
|
|
||
| class NoopSpan(object): |
There was a problem hiding this comment.
In java we call this BlankSpan, because people may use this even for a request that they don't want to trace.
There was a problem hiding this comment.
Changed NoopSpan to BlankSpan...
…-python into noop-tracer-enhancement-issues-277
…-python into noop-tracer-enhancement-issues-277
|
/cc @liyanhui1228 for review |
|
Is the |
…-python into noop-tracer-enhancement-issues-277
…kale22/opencensus-python into noop-tracer-enhancement-issues-277
|
@liyanhui1228 Thanks for the review |
|
Thanks for the fix @mayurkale22 and @bogdandrutu @liyanhui1228 for the review! I just have one minor nit: in the future please refer to issues in the commit message so that Github can auto-close them on merge to the main branch e.g. trace: make a NoopTracer that drops spans instead of crashing
....[Rest of message]....
Fixes #277that way I'd have gotten the notification 11 days ago on it being closed with a PR instead of almost 2 weeks later :) |
No description provided.