This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Enable the configuration of https#290
Merged
liyanhui1228 merged 3 commits intocensus-instrumentation:masterfrom Aug 29, 2018
Merged
Enable the configuration of https#290liyanhui1228 merged 3 commits intocensus-instrumentation:masterfrom
liyanhui1228 merged 3 commits intocensus-instrumentation:masterfrom
Conversation
bogdandrutu
approved these changes
Aug 29, 2018
|
Please rebase your branch. |
bogdandrutu
reviewed
Aug 29, 2018
| 'ZIPKIN_EXPORTER_SERVICE_NAME': 'my_service', | ||
| 'ZIPKIN_EXPORTER_HOST_NAME': 'localhost', | ||
| 'ZIPKIN_EXPORTER_PORT': 9411, | ||
| 'ZIPKIN_EXPORTER_PROTOCOL': 'http', |
There was a problem hiding this comment.
Shouldn't this not require to be set?
Contributor
Author
There was a problem hiding this comment.
None of them are required, they all have defaults in opencensus/trace/exporters/zipkin_exporter.py and opencensus/trace/ext/flask/flask_middleware.py. I thought it was better to follow what was done with the others.
geobeau
changed the title
liyanhui1228
approved these changes
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the ability to configure Zipkin in https