This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Add helper class for stats/metrics conversion#355
Merged
c24t merged 4 commits intocensus-instrumentation:masterfrom Oct 22, 2018
Merged
Add helper class for stats/metrics conversion#355c24t merged 4 commits intocensus-instrumentation:masterfrom
c24t merged 4 commits intocensus-instrumentation:masterfrom
Conversation
helly25
approved these changes
Oct 19, 2018
mayurkale22
reviewed
Oct 20, 2018
| raise AssertionError # pragma: NO COVER | ||
|
|
||
|
|
||
| def get_metric_descriptor(view): |
Member
There was a problem hiding this comment.
Can we change it to view_to_ metric_descriptor ?
mayurkale22
reviewed
Oct 20, 2018
mayurkale22
approved these changes
Oct 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff adds a utility module for converting stats to metrics, and is the first step to producing metrics by way of views, as in https://github.com/census-instrumentation/opencensus-java/pull/1338/files.
Addresses #335.