This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Remove trace class#39
Merged
liyanhui1228 merged 11 commits intocensus-instrumentation:masterfrom Oct 20, 2017
Merged
Conversation
duggelz
approved these changes
Oct 20, 2017
| import uuid | ||
|
|
||
|
|
||
| def generate_trace_id(): |
There was a problem hiding this comment.
Would it make sense to put generate_trace_id() and generate_span_id() in span_context.py? Related, from the discussion yesterday, should we remove span_id from Span, and have Span contain a SpanContext?
Contributor
Author
There was a problem hiding this comment.
Moved to span_context.py. Yes will move SpanContext to Span in later PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37.