Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Conversation

@c24t
Copy link
Member

@c24t c24t commented Nov 27, 2018

Replaces DistributionValue's bucket_bounds with a new BucketOptions class following the spec. This is a pretty mechanical implementation of the spec, the precondition checks come straight from the spec's comments.

This branch includes changes from #406, I'll rebase once that PR is merged.

Fixes #399.

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall !

@c24t c24t merged commit dbfc325 into census-instrumentation:master Nov 30, 2018
@c24t c24t deleted the bucket-options branch November 30, 2018 01:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants