This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Add Jaeger host/port settings#462
Merged
reyang merged 5 commits intocensus-instrumentation:masterfrom Jan 22, 2019
tpyo:django-jaeger-host-settings
Merged
Add Jaeger host/port settings#462reyang merged 5 commits intocensus-instrumentation:masterfrom tpyo:django-jaeger-host-settings
reyang merged 5 commits intocensus-instrumentation:masterfrom
tpyo:django-jaeger-host-settings
Conversation
reyang
reviewed
Jan 22, 2019
| transport=transport) | ||
| host_name=_jaeger_host_name, | ||
| port=_jaeger_port, | ||
| agent_host_name=_jaeger_agent_host_name, |
Contributor
There was a problem hiding this comment.
Do we want agent_host_name and agent_port in Flask Middleware?
Contributor
Author
There was a problem hiding this comment.
Yep, can add to this PR if you like?
reyang
approved these changes
Jan 22, 2019
Contributor
reyang
left a comment
reyang
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the contribution!
Contributor
|
Thank you @tpyo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Django and Flask middleware currently don't provide the necessary host settings for the Jaeger exporter.
This PR adds HTTP and UDP agent settings to both middlewares.