This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Conversation
reyang
commented
Mar 12, 2019
c24t
approved these changes
Mar 13, 2019
Member
c24t
left a comment
c24t
left a comment
There was a problem hiding this comment.
LGTM, and I think it does make sense to keep the stackdriver trace and stats exporters in the same package.
c24t
added a commit
to c24t/opencensus-python
that referenced
this pull request
Mar 22, 2019
c24t
added a commit
to c24t/opencensus-python
that referenced
this pull request
Mar 22, 2019
c24t
added a commit
that referenced
this pull request
Mar 23, 2019
Add prometheus contrib package from #556.
c24t
pushed a commit
to c24t/opencensus-python
that referenced
this pull request
Mar 26, 2019
1. Extracted Prometheus Stats exporter into opencensus.ext.prometheus. 2. Extracted Stackdriver Stats exporter and reuse opencensus.ext.stackdriver. 3. Renamed opencensus.stats.exporters.base to opencensus.stats.base_exporter. 4. Moved Prometheus/Stackdriver specific document/samples to ext packages.
c24t
pushed a commit
to c24t/opencensus-python
that referenced
this pull request
Mar 26, 2019
1. Extracted Prometheus Stats exporter into opencensus.ext.prometheus. 2. Extracted Stackdriver Stats exporter and reuse opencensus.ext.stackdriver. 3. Renamed opencensus.stats.exporters.base to opencensus.stats.base_exporter. 4. Moved Prometheus/Stackdriver specific document/samples to ext packages.
c24t
added a commit
that referenced
this pull request
Mar 27, 2019
Add stackdriver stats package from #556.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the effort #445.
opencensus.ext.prometheus.opencensus.ext.stackdriver.opencensus.stats.exporters.basetoopencensus.stats.base_exporter.@c24t Would you prefer to use the stackdriver exporter package for both trace and stats, or separate them into two packages?