This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Use utcnow instead of now#569
Merged
c24t merged 1 commit intocensus-instrumentation:masterfrom Mar 20, 2019
Merged
Conversation
songy23
approved these changes
Mar 20, 2019
reyang
approved these changes
Mar 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using
datetime.nowin stats/metrics conversions, which don't mix with the tz-aware datetimes used in stats. This could result in converted points being utc offset many hours off when exported.Ultimately all
datetimes should be removed for #502.