Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Fix code coverage for ext packages#576

Merged
reyang merged 4 commits intomasterfrom
coverage
Mar 23, 2019
Merged

Fix code coverage for ext packages#576
reyang merged 4 commits intomasterfrom
coverage

Conversation

@reyang
Copy link
Copy Markdown
Contributor

@reyang reyang commented Mar 22, 2019

Include extension packages in code coverage test.

@reyang reyang requested review from a team, c24t and songy23 as code owners March 22, 2019 22:56
Comment thread nox.py
session.run(
'py.test',
'--quiet',
'--cov=opencensus',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to specify a project? I've been running with opencensus for the core library and opencensus.ext for the contrib packages.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping that by removing this line, [run] source in .coveragerc would take effect, but I realized it was overwritten by pytest-cov:
https://github.com/pytest-dev/pytest-cov/blob/41eea2e3e28e6f6849104d6526bb633e638f8a0f/src/pytest_cov/plugin.py#L56

@reyang reyang changed the title [WIP] Fix code coverage Fix code coverage for ext packages Mar 23, 2019
@reyang reyang merged commit 49e4cb3 into master Mar 23, 2019
@reyang reyang deleted the coverage branch March 23, 2019 04:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants