Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Minor cleanup#641

Merged
reyang merged 2 commits intomasterfrom
cleanup
May 1, 2019
Merged

Minor cleanup#641
reyang merged 2 commits intomasterfrom
cleanup

Conversation

@reyang
Copy link
Copy Markdown
Contributor

@reyang reyang commented May 1, 2019

No description provided.

@reyang reyang requested review from a team, c24t and songy23 as code owners May 1, 2019 20:24
Comment thread AUTHORS
@@ -1 +0,0 @@
OpenCensus Authors
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how useful this file is, but since all other repos have it, I'd suggest to keep it.

Copy link
Copy Markdown
Contributor Author

@reyang reyang May 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the other GitHub repos (e.g. https://github.com/nodejs/node/blob/master/AUTHORS), it seems the purpose is to keep a list of authors.
If we don't plan to put the actual names, might be good to just remove it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on this - @c24t WDYT?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In C# repo we don't have it https://github.com/census-instrumentation/opencensus-csharp.
In Java repo we have "Google Inc.".

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one in Java is due to historical reason. Previously the license header is "Google Inc." instead of "OpenCensus Authors". Later we changed the header but looks like we forgot to update the AUTHORS file.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to remove it, we've got author info in the setup file too.

@reyang reyang merged commit 56d3d64 into master May 1, 2019
@reyang reyang deleted the cleanup branch May 15, 2019 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants