Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Replace nox-automation with nox#653

Merged
reyang merged 5 commits intomasterfrom
nox
May 14, 2019
Merged

Replace nox-automation with nox#653
reyang merged 5 commits intomasterfrom
nox

Conversation

@reyang
Copy link
Copy Markdown
Contributor

@reyang reyang commented May 14, 2019

One possible way for #652. @c24t

@c24t
Copy link
Copy Markdown
Member

c24t commented May 14, 2019

I agree that this is the better approach (vs #652) in the long term, but it's still causing failing builds now. What do you think about merging #652 now and merging this one once CI is fixed?

@reyang
Copy link
Copy Markdown
Contributor Author

reyang commented May 14, 2019

I agree that this is the better approach (vs #652) in the long term, but it's still causing failing builds now. What do you think about merging #652 now and merging this one once CI is fixed?

Yes I agree. Let's unblock the CI first using #652.

Comment thread .circleci/config.yml
name: Run tests - opencensus
command: |
nox -f nox.py
pip install --upgrade nox
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround to the preinstalled nox. We don't need this once we move to Travis.

@reyang
Copy link
Copy Markdown
Contributor Author

reyang commented May 14, 2019

@c24t CI is fixed.

Copy link
Copy Markdown
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@c24t c24t changed the title Fix build break Replace nox-automation with nox May 14, 2019
@reyang reyang merged commit 38122d4 into master May 14, 2019
@reyang
Copy link
Copy Markdown
Contributor Author

reyang commented May 15, 2019

FYI @lzchen

@reyang reyang deleted the nox branch May 15, 2019 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants