This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Increase batch size in background thread transport#86
Merged
liyanhui1228 merged 5 commits intocensus-instrumentation:masterfrom Nov 28, 2017
Merged
Increase batch size in background thread transport#86liyanhui1228 merged 5 commits intocensus-instrumentation:masterfrom
liyanhui1228 merged 5 commits intocensus-instrumentation:masterfrom
Conversation
chingor13
reviewed
Nov 28, 2017
| self._queue.task_done() | ||
|
|
||
| # Wait for a while before next export | ||
| time.sleep(_WAIT_PERIOD) |
Member
There was a problem hiding this comment.
Will removing the sleep make this into a busy loop and eat CPU?
Contributor
Author
There was a problem hiding this comment.
Yeah agree, changed to reduce the sleep time to 1 second. Just want to make sure the spans are sent within the grace period.
| return True | ||
|
|
||
| with self._lock: | ||
| print('Number of spans pending sent: {}'.format( |
Member
There was a problem hiding this comment.
Is the printing meant to stay or is it just for debugging?
If intentional, should it be some kind of optional, configurable logger instead?
chingor13
approved these changes
Nov 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #85