This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Restructure the package#92
Merged
liyanhui1228 merged 4 commits intocensus-instrumentation:masterfrom Dec 5, 2017
Merged
Conversation
duggelz
approved these changes
Dec 5, 2017
duggelz
left a comment
duggelz
left a comment
There was a problem hiding this comment.
Looks good with a couple minor comments.
| 'Programming Language :: Python :: 3.4', | ||
| 'Programming Language :: Python :: 3.5', | ||
| 'Programming Language :: Python :: Implementation :: CPython', | ||
| 'Programming Language :: Python :: 3.6', |
There was a problem hiding this comment.
I think you accidentally replaced Python 3.5 here, instead of adding 3.6 on the line below.
Contributor
Author
There was a problem hiding this comment.
Good catch, added back.
|
|
||
|
|
||
| @nox.session | ||
| @nox.parametrize('python_version', ['2.7', '3.4', '3.5', '3.6']) |
There was a problem hiding this comment.
The google-cloud-python packages did 'python_version' -> 'py', 'system_tests' -> 'system', 'unit_tests' -> 'unit'. Do you have any opinion on doing the same here? I think I'm fine with either.
| # Run py.test against the system tests. | ||
| session.run( | ||
| 'py.test', | ||
| '-vvv', |
There was a problem hiding this comment.
Is this deliberately verbose, or a debugging line left in by accident?
Contributor
Author
There was a problem hiding this comment.
It's verbose to better see what happens in the system tests, but we can remove it for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #54