Skip to content

Conversation

@thehappydinoa
Copy link
Member

Changes

BREAKING CHANGE: The Censys ASM Client risks api was bumped to v2

Signed-off-by: Aidan Holland <aidan@censys.io>
See #339 for more details

Signed-off-by: Aidan Holland <aidan@censys.io>
@thehappydinoa thehappydinoa self-assigned this Aug 17, 2022
DEFAULT_TIMEOUT: int = 30
"""Default API timeout."""
DEFAULT_USER_AGENT: str = f"censys/{__version__}"
DEFAULT_USER_AGENT: str = f"censys-python/{__version__}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be useful, nice!

)
# Actual call
res = list(self.client.risks.get_risks(**kwargs))
res = list(self.api.get_risks(**kwargs))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean 👍

Copy link

@ericbutera ericbutera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thehappydinoa thehappydinoa merged commit 0321879 into main Aug 17, 2022
@thehappydinoa thehappydinoa deleted the adh/deprecate-risks-v1 branch August 17, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants