Elasticsearch Connector#54
Merged
laskoviymishka merged 2 commits intocentralmind:mainfrom Mar 21, 2025
Merged
Conversation
…with Gemini API key.
| } | ||
|
|
||
| // replacePlaceholders replaces parameters in the "match" clause and other necessary fields | ||
| func replacePlaceholders(query map[string]any, params map[string]any) { |
Contributor
There was a problem hiding this comment.
this is force to support only strng match parametrized-queries, maybe it's better to support instead of that a templated query?
{
"query": {
"match": {
"job": ":${.job}"
}
}
}
by utilize query := elastic.NewTemplateQuery("find_user_tpl") func?
Contributor
There was a problem hiding this comment.
laskoviymishka
pushed a commit
that referenced
this pull request
Mar 25, 2025
* Implemented Elasticsearch connector with connector tests and checked with Gemini API key. * Fixed elasticsearch's searching query from manual to template search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Elasticsearch connector with connector tests and checked with Gemini API key.
Contributor Agreement
By submitting this pull request, I affirm that: