Improvements to the report generation#339
Merged
Conversation
added 3 commits
August 28, 2025 15:22
Plot the legend for a comparison report below the graph, rather than within the axes Change the title format from a float to an int value Signed-off-by: Chris Harris <harriscr@uk.ibm.com>
Add an option to the generate_performance_report.py script to not plot error bars. This will default to False to keep the existing behaviour. Signed-off-by: Chris Harris <harriscr@uk.ibm.com>
Add a noption to the report generators to force a refresh of the intermediate files and plots Signed-off-by: Chris Harris <harriscr@uk.ibm.com>
Contributor
Author
Teuthology runs:perf-basichttps://pulpito.ceph.com/harriscr-2025-09-02_10:27:08-perf-basic-main-distro-default-smithi/
rados/perfhttps://pulpito.ceph.com/harriscr-2025-09-02_10:29:00-rados:perf-main-distro-default-smithi/
|
lee-j-sanders
approved these changes
Sep 5, 2025
Member
lee-j-sanders
left a comment
lee-j-sanders
left a comment
There was a problem hiding this comment.
A couple of very minor typos, otherwise looks good to me. Thanks!
Comments from the code review Signed-off-by: Chris Harris <harriscr@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few quality of life improvements to the report generation added in #320 #321 and #322.
The automatic placement was good in most cases, but there were odd cases where data was obscured
e.g. 1024K instead of 1024.0K
It was found that some error bars were so big that they ended up distorting the axes and stretching the plot
In 3, and 4 above the current behaviour will remain the default. For 1 and 2 this will become the new default as it makes the charts look better.