This repository was archived by the owner on Mar 16, 2026. It is now read-only.
consistently remove domain from short hostname#72
Merged
alfredodeza merged 2 commits intoceph:masterfrom Sep 11, 2013
Merged
Conversation
Signed-off-by: Dmitry Borodaenko <angdraug@gmail.com>
ceph_deploy/tests/unit/test_mon.py
Outdated
Contributor
There was a problem hiding this comment.
this looks like two tests :)
Signed-off-by: Dmitry Borodaenko <angdraug@gmail.com>
Collaborator
|
Can one of the admins verify this patch? |
alfredodeza
added a commit
that referenced
this pull request
Sep 11, 2013
consistently remove domain from short hostname
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the unnecessary warning thrown by ceph-deploy mon create when host:ip notation is used to specify the mon and the remote host reports an fqdn as its hostname:
http://tracker.ceph.com/issues/6269
The hostname handling code is extracted into remote_shortname() method in ceph_deploy.misc and reused across ceph-deploy to improve consistency.