Skip to content

go-ceph: require a newer version of testify#671

Merged
mergify[bot] merged 1 commit intoceph:masterfrom
phlogistonjohn:jjm-newer-testify
Apr 22, 2022
Merged

go-ceph: require a newer version of testify#671
mergify[bot] merged 1 commit intoceph:masterfrom
phlogistonjohn:jjm-newer-testify

Conversation

@phlogistonjohn
Copy link
Collaborator

The older version has some bugs fixed in newer releases. These issues
were exposed on patches not yet merged. We can take this now and
rebase those more complex patch series afterwards.

Signed-off-by: John Mulligan jmulligan@redhat.com

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Is this new API marked PREVIEW?

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Apr 18, 2022
@phlogistonjohn phlogistonjohn requested a review from ansiwen April 18, 2022 17:31
@phlogistonjohn
Copy link
Collaborator Author

@Mergifyio rebase

The older version has some bugs fixed in newer releases. These issues
were exposed on patches not yet merged. We can take this now and
rebase those more complex patch series afterwards.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@mergify
Copy link

mergify bot commented Apr 22, 2022

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit 13b2769 into ceph:master Apr 22, 2022
@phlogistonjohn phlogistonjohn deleted the jjm-newer-testify branch June 27, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-API This PR does not include any changes to the public API of a go-ceph package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants