Merged
Conversation
phlogistonjohn
force-pushed
the
jjm-doc-pkg
branch
from
01b2b3d to
01cd213
Compare
phlogistonjohn
changed the title
phlogistonjohn
force-pushed
the
jjm-doc-pkg
branch
from
01cd213 to
8b4a55d
Compare
phlogistonjohn
added
the
no-API
anoopcs9
reviewed
Aug 11, 2022
Collaborator
anoopcs9
left a comment
anoopcs9
left a comment
There was a problem hiding this comment.
Fair enough.
See below for a typo 😛
A recent change in revive broke the package-comments rule when .go files are input individually. (see mgechev/revive#694) See the comment within for more info. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
phlogistonjohn
force-pushed
the
jjm-doc-pkg
branch
from
8b4a55d to
988aa0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the newest version of revive there appears to be no way to have it both check all .go files individually and have it properly detect the package-comments rule.
I took the lazy way out and simply disabled the rule in the config file rather than try to do something more complicated.
Fixes: #754