refactor: remove offset/limit where too generic#624
Merged
nathanielc merged 2 commits intomainfrom Dec 4, 2024
Merged
Conversation
This change removes the offset/limit pagination pattern where it implies a more flexible API than was needed or used. Having the flexible API meant that casts from usize to smaller types for limits and offsets could break pagination assumptions. Now with this change more specific APIs are exposed where its safe to make assumptions about the size of limit offset values in queries. Additionally in the API where true pagination was the desired API u32 is used instead of usize to keep page sizes small. Finally, the range_with_values method on the Recon trait was removed as it was unused
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
nathanielc
changed the title
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
dav1do
approved these changes
Dec 4, 2024
Collaborator
dav1do
left a comment
dav1do
left a comment
There was a problem hiding this comment.
Nice, looks like an improvement. Thanks for doing this.
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the offset/limit pagination pattern where it implies a more flexible API than was needed or used. Having the flexible API meant that casts from usize to smaller types for limits and offsets could break pagination assumptions. Now with this change more specific APIs are exposed where its safe to make assumptions about the size of limit offset values in queries.
Additionally in the API where true pagination was the desired API u32 is used instead of usize to keep page sizes small.
Finally, the range_with_values method on the Recon trait was removed as it was unused