Use the ':git' source when bundling Rails master #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per http://bundler.io/git.html: > `http://` and `git://` URLs are insecure. A man-in-the-middle attacker > could tamper with the code as you check it out, and potentially supply > you with malicious code instead of the code you meant to check > out. Because the `:github` shortcut uses a `git://` URL in Bundler 1.x > versions, we recommend using using HTTPS URLs or overriding the > `:github` shortcut with your own HTTPS git source. Also, as Rails master (currently 5.0.0.alpha) has a dependency on Arel master (currently 7.0.0.alpha), we must pull this in too.
Member
|
I would hope no one's pulling from master for anything but development (i.e. probably not a realistic concern for production apps). But regardless, seems like a good precaution. 👍 |
lgebhardt
added a commit
that referenced
this pull request
Sep 2, 2015
Use the ':git' source when bundling Rails master
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per http://bundler.io/git.html:
Also, as Rails master (currently 5.0.0.alpha) has a dependency on Arel
master (currently 7.0.0.alpha), we must pull this in too.